-
Notifications
You must be signed in to change notification settings - Fork 166
Firedrake release #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firedrake release #4193
Conversation
Are you really sure you want to go down this road? You've put months of efforts into removing Wouldn't it be possible to reuse |
The issue is the process for installing I guess I'm trying to make it easier for people to I was thinking that this script would be written in bash and very simple, just containing a list of commands with little to no control flow. It would be handy in CI too. |
Could we not just have a different pyproject.toml on main compared with release? |
The trouble is we have to build with |
I'd say so. For instance, I would guess that on the release branch there is a dependency on "fenics-ufl" (i.e., from PyPI), and on the main branch there is one on "fenics-ufl @ git://github@main", and part of the process of creating a new release would be to remind yourselves to drop the references to the github repository.
What does "disables" mean? My understanding is that it disables automatically fetching For instance, at |
Oh interesting! I was led to believe that this was not the case. In that case I think we are safe to maintain different |
There are effectively 3 entrypoints to the actions: pull request, push or release. These all rely to some extent on the same process of building and testing so everything goes through the build.yml file.
I am forcing this through now as the release process HAS BEGUN! |
Summary
This PR is a place to collect the final changes that are necessary for a release to be made.
In terms of process, I think we should, once all dependent PRs are sorted:
release
branchmain
, amendpyproject.toml
to point to git repos and add dev install informationTODOs
Installation
2025.4.0
inpyproject.toml
- [ ] Writefiredrake-dev-install
, a script that lets users install a usable Firedrakemain
and associated packages (there will not be an associatedfiredrake-update
and likefiredrake-configure
it will be extremely dumb)Workflows
main
andrelease
branches (the install procedure will be slightly different due to needing--no-build-isolation
for the former)main
.NOTE: I have removed the zenodo canary workflow. It used
firedrake-install
.Zenodo
firedrake-zenodo
as appropriateinstall.rst
about itIMPORTANT: Testing
firedrake-zenodo
is quite the pain and so I have not tested the core dev half of the script. My thinking is that we can fix this when someone actually asks us to make a release and we need to run it for real. I have checked that the initial generation offiredrake.json
works.Documentation
main
website)See also the release GitHub project (I am choosing not to use this here because I don't want to create a million issues that all get closed in a single PR).