-
Notifications
You must be signed in to change notification settings - Fork 166
Clarify install docs #4121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify install docs #4121
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good improvements. I just have a few suggestions for the PETSc installation details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While clarifying install docs, perhaps we should add git+https
to the suggested cloning commands for developer-mode install. Currently, it is http-only and one can't go over ssh/is prompted to supply GitHub credentials if one has followed the commands too slavishly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure downstream packages installed in developer mode get installed via git
@rckirby I'm not quite sure what you mean by this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But please delete the petsc/slepc version changes
Forcing this through as it was previously approved and is holding up other PRs. |
Description
firedrake-install
pip cache remove petsc4py
a main instruction so it isn't missedFixes #4097 and #4098
Note that the docs link check is expected to fail because it references a link that doesn't yet exist.
TODOs
--extra-index-url
?)