Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIAM] Fix an objc_retain crash #12395

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[FIAM] Fix an objc_retain crash #12395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseInAppMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 10.22.0
- [fixed] Fixed an `objc_retain` crash. (#12393)

# 10.17.0
- [deprecated] All of the public API from `FirebaseInAppMessagingSwift` can now
be accessed through the `FirebaseInAppMessaging` module. Therefore,
Expand Down
6 changes: 4 additions & 2 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMMessageClientCache.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ - (void)setupAnalyticsEventListening {
}

- (BOOL)hasTestMessage {
return self.testMessages.count > 0;
@synchronized(self) {
return self.testMessages.count > 0;
}
}

- (nullable FIRIAMMessageDefinition *)nextOnAppLaunchDisplayMsg {
Expand All @@ -135,7 +137,7 @@ - (nullable FIRIAMMessageDefinition *)nextOnAppLaunchDisplayMsg {

- (nullable FIRIAMMessageDefinition *)nextOnAppOpenDisplayMsg {
@synchronized(self) {
// always first check test message which always have higher prirority
// always first check test message which always have higher priority
if (self.testMessages.count > 0) {
FIRIAMMessageDefinition *testMessage = self.testMessages[0];
// always remove test message right away when being fetched for display
Expand Down
Loading