Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIAM] Fix an objc_retain crash #12395

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[FIAM] Fix an objc_retain crash #12395

merged 1 commit into from
Feb 16, 2024

Conversation

paulb777
Copy link
Member

Fix #12393

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Feb 15, 2024
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from 44.72% (ab0d085) to 44.74% (785c6ab) by +0.02%.

    FilenameBase (ab0d085)Merge (785c6ab)Diff
    FIRIAMMessageClientCache.m78.11%78.36%+0.26%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FrNLFUahMd.html

@paulb777 paulb777 added this to the 10.22.0 - M144 milestone Feb 15, 2024
@paulb777
Copy link
Member Author

Going to merge here. I'll address any additional comments in a subsequent PR.

@paulb777 paulb777 merged commit 4a8f84b into main Feb 16, 2024
47 checks passed
@paulb777 paulb777 deleted the pb-fiam-fix branch February 16, 2024 16:34
@firebase firebase locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@eldhosembabu eldhosembabu Awaiting requested review from eldhosembabu

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
10.22.0 - M144
Development

Successfully merging this pull request may close these issues.

[FIRIAMMessageClientCache hasTestMessage] crashes the app
3 participants
@paulb777 @google-oss-bot @andrewheard