Skip to content

Commit

Permalink
[App Check] Fix warning due to NSUInteger length on watchOS (#11974)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewheard authored Oct 20, 2023
1 parent 3af0241 commit 3e4b721
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/firebase_app_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
podspec: [FirebaseAppCheckInterop.podspec, FirebaseAppCheck.podspec]
target: [ios, tvos, macos]
target: [ios, tvos, macos, watchos]
steps:
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
Expand Down
4 changes: 2 additions & 2 deletions FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.m
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ + (NSError *)appAttestAttestKeyFailedWithError:(NSError *)error
[NSString stringWithFormat:@"Failed to attest the validity of the generated cryptographic "
@"key (`attestKey:clientDataHash:completionHandler:`); "
@"keyId.length = %lu, clientDataHash.length = %lu",
keyId.length, clientDataHash.length];
(unsigned long)keyId.length, (unsigned long)clientDataHash.length];
// TODO(#11967): Add a new error code for this case (e.g., FIRAppCheckAppAttestAttestKeyFailed).
return [self appCheckErrorWithCode:FIRAppCheckErrorCodeUnknown
failureReason:failureReason
Expand All @@ -150,7 +150,7 @@ + (NSError *)appAttestGenerateAssertionFailedWithError:(NSError *)error
stringWithFormat:@"Failed to create a block of data that demonstrates the legitimacy of the "
@"app instance (`generateAssertion:clientDataHash:completionHandler:`); "
@"keyId.length = %lu, clientDataHash.length = %lu.",
keyId.length, clientDataHash.length];
(unsigned long)keyId.length, (unsigned long)clientDataHash.length];
// TODO(#11967): Add error code for this case (e.g., FIRAppCheckAppAttestGenerateAssertionFailed).
return [self appCheckErrorWithCode:FIRAppCheckErrorCodeUnknown
failureReason:failureReason
Expand Down

0 comments on commit 3e4b721

Please sign in to comment.