Skip to content

Commit

Permalink
Update OR query Swift tests. (#11969)
Browse files Browse the repository at this point in the history
  • Loading branch information
ehsannas authored Oct 20, 2023
1 parent 33cf815 commit 3af0241
Showing 1 changed file with 0 additions and 33 deletions.
33 changes: 0 additions & 33 deletions Firestore/Swift/Tests/Integration/QueryIntegrationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -185,31 +185,6 @@ class QueryIntegrationTests: FSTIntegrationTestCase {
matchesResult: ["doc3", "doc4", "doc6"])
}

func testOrQueriesWithNotIn() throws {
// TODO(orquery): Enable this test against production when possible.
try XCTSkipIf(!FSTIntegrationTestCase.isRunningAgainstEmulator(),
"Skip this test if running against production because it results in " +
"a 'missing index' error. The Firestore Emulator, however, does serve these queries")

let collRef = collectionRef(
withDocuments: ["doc1": ["a": 1, "b": 0],
"doc2": ["b": 1],
"doc3": ["a": 3, "b": 2],
"doc4": ["a": 1, "b": 3],
"doc5": ["a": 1],
"doc6": ["a": 2]]
)

// a==2 || b not-in [2,3]
// Has implicit orderBy b.
let filter = Filter.orFilter(
[Filter.whereField("a", isEqualTo: 2),
Filter.whereField("b", notIn: [2, 3])]
)
checkOnlineAndOfflineQuery(collRef.whereFilter(filter),
matchesResult: ["doc1", "doc2"])
}

func testOrQueriesWithArrayMembership() throws {
let collRef = collectionRef(
withDocuments: ["doc1": ["a": 1, "b": [0]],
Expand Down Expand Up @@ -238,10 +213,6 @@ class QueryIntegrationTests: FSTIntegrationTestCase {
}

func testMultipleInOps() throws {
// TODO(orquery): Enable this test against production when possible.
try XCTSkipIf(!FSTIntegrationTestCase.isRunningAgainstEmulator(),
"Skip this test if running against production because it's not yet supported.")

let collRef = collectionRef(
withDocuments: ["doc1": ["a": 1, "b": 0],
"doc2": ["b": 1],
Expand Down Expand Up @@ -270,10 +241,6 @@ class QueryIntegrationTests: FSTIntegrationTestCase {
}

func testUsingInWithArrayContainsAny() throws {
// TODO(orquery): Enable this test against production when possible.
try XCTSkipIf(!FSTIntegrationTestCase.isRunningAgainstEmulator(),
"Skip this test if running against production because it's not yet supported.")

let collRef = collectionRef(
withDocuments: ["doc1": ["a": 1, "b": [0]],
"doc2": ["b": [1]],
Expand Down

0 comments on commit 3af0241

Please sign in to comment.