feat: Added pvc accessModes support #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandawg
force-pushed
the
pvc-accessmodes
branch
from
15b7b61 to
8863e76
Compare
tchughesiv
reviewed
Dec 13, 2024
tchughesiv
reviewed
Dec 16, 2024
tchughesiv
reviewed
Dec 16, 2024
tchughesiv
reviewed
Dec 16, 2024
infra/feast-operator/internal/controller/featurestore_controller_pvc_test.go
Outdated
Show resolved
Hide resolved
Done. Thanks for the reminder. |
tchughesiv
reviewed
Dec 19, 2024
Signed-off-by: dandawg <[email protected]>
Signed-off-by: dandawg <[email protected]>
Signed-off-by: dandawg <[email protected]>
Signed-off-by: dandawg <[email protected]>
dandawg
force-pushed
the
pvc-accessmodes
branch
from
3144171 to
f02f797
Compare
tchughesiv
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the feast services structure to allow for users to use a valid PVC accessModes list of their choosing. The default is set to ["ReadWriteOnce"], for cases where a PVC config is included in the spec, but the accessModes field is not included.
Previously, the PVC accessModes list was hard-coded to ["ReadWriteMany"] (for each of the Feast services where PVCs were used).
Which issue(s) this PR fixes:
#4853
Misc