Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PVC accessModes in Feast Go operator #4853

Open
dandawg opened this issue Dec 16, 2024 · 0 comments
Open

Support PVC accessModes in Feast Go operator #4853

dandawg opened this issue Dec 16, 2024 · 0 comments
Labels
kind/feature New feature or request

Comments

@dandawg
Copy link
Contributor

dandawg commented Dec 16, 2024

Is your feature request related to a problem? Please describe.
Currently when deploying Feast PVC-backed services with the Feast Go operator, the accessModes list is hard coded to ["ReadWriteMany"]. Different use cases will likely require setting the accessModes list to something different, and users should be able to make the choice of which access modes they would like for each of the Feast services (Online, Offline, Registry) that have PVC-backed storage.

Describe the solution you'd like
We propose adding an accessModes field to spec.services.<service>.persistence.file.pvc.create in the FeatureStore CRD. Users would then be able to set this field when deploying Feast resources.

  spec:
    feastProject: sample
    services:
      onlineStore:
        persistence:
          file:
            pvc:
              create:
                accessModes:
                - ReadWriteOnce
                - ReadWriteMany

We will also update the Feast Go operator to take care of setting and managing the PVC accessModes.
As part of this change, we propose setting the default access mode to ReadWriteOnce (the setting used if a user requires a PVC, but doesn't explicitly provide the accessModes field in the resource YAML).

Describe alternatives you've considered
The current functionality is that PVC access modes are hard coded to one value (in the Feast operator), and the user has no choice.

Additional context
Work for this issue is progressing in PR #4851.
Docs on PVCs: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#persistentvolumeclaims

@dandawg dandawg added the kind/feature New feature or request label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant