serve local file for background image #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksqsf
approved these changes
Jul 4, 2024
| @State private var openPanel = NSOpenPanel() | ||
|
|
||
| func selectImage() { | ||
| mkdirP(imageDir.localPath()) |
There was a problem hiding this comment.
(This seems not satisfying, but acceptable anyway)
| var fileName = file.lastPathComponent | ||
| if !imageDir.contains(file) { | ||
| if !copyFile(file, imageDir.appendingPathComponent(fileName)) { | ||
| return |
There was a problem hiding this comment.
I think we should add an error message here, at least in the log file
There was a problem hiding this comment.
copyFile already logs on fail.
What I want to improve in the future is to provide a convenient way to trigger an AlertToast from nested subview to window's major view. Currently the only place that does the similar thing is
fcitx5-macos/src/config/inputmethod.swift
Lines 215 to 228 in e14a44a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please update submodule on merge.