-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-6679: Introduce support for changefeeds #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README looks good aside from some minor nits. I'll work on getting the docs.fauna.com docs ready.
987b21e
to
1048efd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my code comments are resolved. I'm not certain what you would consider the new, idiomatic error handling on the user side.
We can gather feedback from python folks during the python bug bash this Friday. |
cdc7e75
to
04f9ccd
Compare
04f9ccd
to
f4d4f05
Compare
c935ab9
to
68592d9
Compare
I'll need another 🐑. I've marked the feature as beta in the readme file. |
68592d9
to
9ea9305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑 it.
Co-authored-by: James Rodewig <[email protected]>
Description
Add changefeeds support to the Python driver.
Motivation and context
Changefeeds allows to interactively poll from a stream instead of having it open at all times. It's useful for cron jobs and other forms of periodic tasks to sync 3rd party systems.
How was the change tested?
Unit tests are included.
Screenshots (if appropriate):
NA
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.