Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE-5985] Error when configuring start_ts and cursor at the same time #199

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Oct 10, 2024

FE-5985

Description

Added additional input validation for StreamIterator and ChangeFeedIterator constructors: raise an error if both cursor and start_ts are provided as options.

Motivation and context

We currently allow both start_ts and cursor options to be provided at the same time for Streams and ChangeFeeds. When that happens, cursor is used and start_ts is silently ignored. We should raise an error instead.

This is a follow up to a previous discussion: #192 (comment)

How was the change tested?

Additional integration tests were added to confirm an error is raised.

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)
      • The cursor option is part of the beta release of change feeds, so while technically breaking, it only breaks the experimental/beta features that have been released.

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptpaterson ptpaterson merged commit 4d25b58 into main Oct 10, 2024
6 checks passed
@ptpaterson ptpaterson deleted the fe-5985-stream-changefeed-configs branch October 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants