[FE-5985] Error when configuring start_ts and cursor at the same time #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FE-5985
Description
Added additional input validation for
StreamIterator
andChangeFeedIterator
constructors: raise an error if bothcursor
andstart_ts
are provided as options.Motivation and context
We currently allow both start_ts and cursor options to be provided at the same time for Streams and ChangeFeeds. When that happens,
cursor
is used andstart_ts
is silently ignored. We should raise an error instead.This is a follow up to a previous discussion: #192 (comment)
How was the change tested?
Additional integration tests were added to confirm an error is raised.
Screenshots (if appropriate):
Change types
cursor
option is part of the beta release of change feeds, so while technically breaking, it only breaks the experimental/beta features that have been released.Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.