Refactorisation #93
Merged
Refactorisation #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-michelet
requested review from
delvedor,
climba03003,
Fdawgs and
gurgunday
and removed request for
delvedor
2 tasks
gurgunday
approved these changes
Mar 30, 2025
|
@fastify/collaborators |
metcoder95
approved these changes
Apr 8, 2025
|
This was referenced Apr 14, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of this PR
Encapsulate more logic into utility plugins
Our controllers are currently handling too many responsibilities: database queries, file uploads, and more. IMO, they should focus only on handling HTTP concerns. I made some improvements in this direction, but there's still work to be done. I believe introducing a service layer or a set of use-cases would help to achieve this separation.
Better logging
I think relying on the
reply.internalServerError()utility from@fastify/sensibleis not very useful, and we were essentially blind to the actual reasons why transactions were failing (credits to @fraxken). If we don't implement fine-grained logging, it's better to let errors propagate naturally. The default error handler already does a good job of adding context to thrown errors.Hotfixes
I also took the opportunity to address #38 by implementing the temporary file approach recommended by @climba03003 here.
Future improvements
getDecorator<T>api on next minor, see feat: allow to access decorators fastify#5768