fix: delete file if exist before uploading another one

[Turn0xx]

-I couldn't do this with one query because MySql doesn't support RETURNING clause
-For retriveal tests I had to build a clean state for them to work because they were depending on Upload tests

Issue: #38

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[jean-michelet]

Install and run Sonarqube locally before pushing. They are also editor extensions.

…

On Sat, Nov 2, 2024, 16:38 sonarcloud[bot] ***@***.***> wrote: [image: Quality Gate Failed] <https://sonarcloud.io/dashboard?id=fastify_demo&pullRequest=50> *Quality Gate failed* Failed conditions <https://camo.githubusercontent.com/bd1d5234b37410841ad8cd9d85c84eeecaec92ae18a95c926ae3a59a17c29a65/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6661696c65642d313670782e706e67> 15.1% Duplication on New Code <https://sonarcloud.io/component_measures?id=fastify_demo&pullRequest=50&metric=new_duplicated_lines_density&view=list> (required ≤ 3%) See analysis details on SonarCloud <https://sonarcloud.io/dashboard?id=fastify_demo&pullRequest=50> — Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2J2327TMKPDVVCXZLW4KATZ6TWXVAVCNFSM6AAAAABQZ6NND6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGAZDKOJTGQ> . You are receiving this because you commented.Message ID: ***@***.***>

[jean-michelet]

Take a look at my feedbacks plz.

Besides that, LGTM!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarCloud

[jean-michelet]

Can I merge @climba03003 @Fdawgs?

[climba03003]

I would go for temporary file approach.

1. Save the file with random name.
2. Remove the old file.
3. Move the tmp file to proper location.

It can ensure when the transaction is rollback or file upload is failed.
You still have the copy of old file.

[jean-michelet]

Do you plan to terminate this PR @Turn0xx? Or should I terminate it for you?

[Turn0xx]

@jean-michelet I plan to finish it, but i don't have much time this weeks so i don't know when.

[jean-michelet]

Fixed by #93