Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] DFS depths when starting from inline node #7179

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

fantactuka
Copy link
Contributor

Missed in #7174 that depth was not calculated properly if we're starting iterator from inline node. In that case depth of its parent was used:

    P
T1 T2 T3
$dfs(T2) -> [[depth: 1, node: T2], [depth: 1, node: T3]]

while expected

$dfs(T2) -> [[depth: 2, node: T2], [depth: 2, node: T3]]

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:35pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:35pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2025
@fantactuka fantactuka requested a review from etrepum February 14, 2025 17:40
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Feb 14, 2025
@ivailop7 ivailop7 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit ad2511c Feb 14, 2025
73 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants