[fix] DFS depths when starting from inline node (#7179)

facebook · Feb 14, 2025 · ad2511c · ad2511c
1 parent b3c64f1
commit ad2511c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/lexical-utils/src/__tests__/unit/LexicalNodeHelpers.test.ts b/packages/lexical-utils/src/__tests__/unit/LexicalNodeHelpers.test.ts
@@ -202,9 +202,9 @@ describe('LexicalNodeHelpers tests', () => {
 
             const paragraph = root.getFirstChildOrThrow<ElementNode>();
             const children = paragraph.getChildren();
-            expect($dfs(children[1]).map((step) => step.node)).toEqual([
-              children[1],
-              children[2],
+            expect($dfs(children[1])).toEqual([
+              {depth: 2, node: children[1]},
+              {depth: 2, node: children[2]},
             ]);
           },
           {discrete: true},

diff --git a/packages/lexical-utils/src/index.ts b/packages/lexical-utils/src/index.ts
@@ -247,7 +247,7 @@ function $dfsCaretIterator<D extends CaretDirection>(
   const startCaret = $isElementNode(start)
     ? $getChildCaret(start, direction)
     : $getSiblingCaret(start, direction);
-  const startDepth = $getDepth(startCaret.getParentAtCaret());
+  const startDepth = $getDepth(start);
   const endCaret = $getAdjacentChildCaret(
     endNode
       ? $getChildCaretOrSelf($getSiblingCaret(endNode, direction))