Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set deprecation for sooner (warning has been around for a year) #2351

Closed
wants to merge 2 commits into from
Closed

Set deprecation for sooner (warning has been around for a year) #2351

wants to merge 2 commits into from

Commits on Apr 11, 2024

  1. Move ei_or_nei out of ALEBO and to botorch_defaults so LCE-A does… 

    …n't depent on it

Summary:
Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them.

Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address.

**[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?**

Differential Revision: D56037477
    @facebook-github-bot
    Lena Kashtelyan authored and facebook-github-bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0923e56 View commit details
    Browse the repository at this point in the history

  2. Set deprecation for sooner (warning has been around for a year) 

    Summary:
Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of GenerationStrategy, which these classes hack around, so there's substantial maintenance burden to keeping them.

Context for this diff, RfC: 0.5.0 is a long-ways away. Let's deprecate these in the version after next one we cut.

Reviewed By: saitcakmak

Differential Revision: D56038505
    @facebook-github-bot
    Lena Kashtelyan authored and facebook-github-bot committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    007059b View commit details
    Browse the repository at this point in the history