Set deprecation for sooner (warning has been around for a year) #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2024 15:21
…n't depent on it Summary: Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them. Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address. **[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?** Differential Revision: D56037477
Summary: Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of GenerationStrategy, which these classes hack around, so there's substantial maintenance burden to keeping them. Context for this diff, RfC: 0.5.0 is a long-ways away. Let's deprecate these in the version after next one we cut. Reviewed By: saitcakmak Differential Revision: D56038505
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56038505 |
|
This pull request has been merged in bedc207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of GenerationStrategy, which these classes hack around, so there's substantial maintenance burden to keeping them.
Context for this diff, RfC: 0.5.0 is a long-ways away. Let's deprecate these in the version after next one we cut.
Reviewed By: saitcakmak
Differential Revision: D56038505