Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorials to stop using legacy models #1982

Closed
wants to merge 4 commits into from
Closed

Update tutorials to stop using legacy models #1982

wants to merge 4 commits into from

Conversation

dme65
Copy link
Contributor

@dme65 dme65 commented Nov 10, 2023

  • The only legacy model remaining is a call to get_MOO_PAREGO in the MOO tutorial.
  • I also cleaned up some imports and got rid of a few from ax import *.

@dme65
Update Ax tutorials to stop using legacy Ax models
4c74a37 
- The only legacy model remaining is a call to `get_MOO_PAREGO` in the MOO tutorial.
- I also cleaned up some imports and got rid of a few `from ax import *`.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

saitcakmak pushed a commit to saitcakmak/Ax that referenced this pull request Nov 10, 2023
@dme65 @facebook-github-bot
Update Ax tutorials to stop using legacy Ax models (facebook#1982)
f55e089 
Summary:
- The only legacy model remaining is a call to `get_MOO_PAREGO` in the MOO tutorial.
- I also cleaned up some imports and got rid of a few `from ax import *`.

Pull Request resolved: facebook#1982

Differential Revision: D51214898

fbshipit-source-id: 9d937e2795dc7046adb22b23ae3e3f7c5dbe64fd
@dme65 dme65 changed the title Update Ax tutorials to stop using legacy Ax models Update tutorials to stop using legacy models Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1186380) 94.46% compared to head (4b12614) 94.46%.

❗ Current head 4b12614 differs from pull request most recent head 1537ae6. Consider uploading reports for the commit 1537ae6 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         460      460           
  Lines       44032    44032           
=======================================
  Hits        41595    41595           
  Misses       2437     2437

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@dme65 merged this pull request in a2f5725.

@saitcakmak saitcakmak deleted the update_ax_tutorials branch April 10, 2024 19:51
@bernardbeckerman bernardbeckerman mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dme65 @facebook-github-bot @codecov-commenter