Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOO Tutorial potentially incorrect model #2452

Closed
basarkutukcu opened this issue May 13, 2024 · 3 comments
Closed

MOO Tutorial potentially incorrect model #2452

basarkutukcu opened this issue May 13, 2024 · 3 comments
Assignees
Labels
documentation Additional documentation requested

Comments

@basarkutukcu
Copy link

In MOO Tutorial notebook (https://ax.dev/tutorials/multiobjective_optimization.html), "get_MOO_EHVI" is imported as below but never used.

# Factory methods for creating multi-objective optimization modesl.
from ax.modelbridge.factory import get_MOO_EHVI, get_MOO_PAREGO

Instead Models.BOTORCH_MODULAR is used. Is this a mistake or intentional?

  ehvi_model = Models.BOTORCH_MODULAR(
      experiment=ehvi_experiment,
      data=ehvi_data,
  )
@bernardbeckerman bernardbeckerman self-assigned this May 14, 2024
@bernardbeckerman bernardbeckerman added the documentation Additional documentation requested label May 14, 2024
@bernardbeckerman
Copy link
Contributor

Thanks for pointing this out! I'll put up a change to rectify this : )

bernardbeckerman pushed a commit to bernardbeckerman/Ax that referenced this issue May 15, 2024
Summary: Reported here: facebook#2452

Reviewed By: mgarrard

Differential Revision: D57359677
facebook-github-bot pushed a commit that referenced this issue May 15, 2024
Summary:
Pull Request resolved: #2462

Reported here: #2452

Reviewed By: mgarrard

Differential Revision: D57359677

fbshipit-source-id: bb83af3d35c3e485c762e71aac04e57fb23e27dd
@basarkutukcu
Copy link
Author

I actually commented on the PR but I think it's hard to see the comment there. I am copying the comment below. @bernardbeckerman What do you think?

Is this the correct fix for the problem? I was expecting a change to use get_MOO_EHVI instead of Models.BOTORCH_MODULAR as following.

      ehvi_model = get_MOO_EHVI(
          experiment=ehvi_experiment,
          data=ehvi_data,
      )

@bernardbeckerman
Copy link
Contributor

This new BOTORCH_MODULAR model type replaced the legacy get_MOO_EHVI in #1982 and should be used in its place going forward. Please let me know if you have further questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Additional documentation requested
Projects
None yet
Development

No branches or pull requests

2 participants