-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOO Tutorial potentially incorrect model #2452
Comments
Thanks for pointing this out! I'll put up a change to rectify this : ) |
Summary: Reported here: facebook#2452 Reviewed By: mgarrard Differential Revision: D57359677
I actually commented on the PR but I think it's hard to see the comment there. I am copying the comment below. @bernardbeckerman What do you think? Is this the correct fix for the problem? I was expecting a change to use
|
This new BOTORCH_MODULAR model type replaced the legacy get_MOO_EHVI in #1982 and should be used in its place going forward. Please let me know if you have further questions! |
In MOO Tutorial notebook (https://ax.dev/tutorials/multiobjective_optimization.html), "get_MOO_EHVI" is imported as below but never used.
Instead Models.BOTORCH_MODULAR is used. Is this a mistake or intentional?
The text was updated successfully, but these errors were encountered: