add Gradle build support, initial version (fixes #118) #121

vorburger · 2018-03-04T13:19:30Z

No description provided.

rhuss

tbh, I'm not a Gradle user at all, so its probably hard for me to support this feature on the long run.

If there are others (@dhirajsb @jamesnetherton ...) willing to support this, I'm happy to integrate the PR.

added some minor comments, too.

BTW, what would you think to add some real shell integration tests with bats, like we do for https://github.com/fabric8io-images/run-java-sh ?

rhuss · 2018-03-05T15:47:55Z

java/images/jboss/s2i/assemble

+
+  # Normalize dir
+  # TODO how do you get this to check not one but two (../..) up?
+#  dir=$(echo ${dir} | tr -s /)


what is this section supposed to do ?

it was inspired by the equivalent for Maven, but things work without this (as proven by java/examples/gradle in upcoming PR), so I've just removed in the new clean-up commit; hope that's OK? It could always be added back later (and covered by the example / test), if really needed.

rhuss · 2018-03-05T15:48:18Z

java/images/jboss/s2i/assemble

@@ -111,6 +136,10 @@ function setup_maven() {
  fi
 }

+function setup_gradle() {


Can we remove it for now if not used ?

Yup, sure, makes sense; so done now in new clean up commit. PS: Just for future reference, see Gradle doc re. proxies - this would have to do something like that, similarly to function setup_maven(), I guess.

rhuss · 2018-03-05T15:49:25Z

java/images/jboss/s2i/assemble

+  local gradle_args=${GRADLE_ARGS:-build -x test}
+
+  # If there is no user provided GRADLE_OPTS, use options from run-java.sh
+  if [ -f ${RUN_JAVA_DIR}/run-java.sh -a -z "${GRADLE_OPTS}" ]; then


using [ .... ] && [ .... ] proved to be more robust to me. -a fails in certain edge case (which I dont remember right now ;-)

Unfortunately my bash foo smartness is not nearly good enough 😃 to understand what exactly you mean here, but FYI I've just copy/pasted this from an almost identical line in build_maven() ... perhaps you would like to raise a follow-up PR, when this is in, to adjust both this and the original that I got inspired from for this however you see fit?

rhuss · 2018-03-05T15:49:44Z

java/images/jboss/s2i/assemble

+    export GRADLE_OPTS=$(${RUN_JAVA_DIR}/run-java.sh options)
+  fi
+
+  if [ ! -z "${GRADLE_OPTS}" ]; then


similarly to above, build_maven() uses if [ ! -z "${MAVEN_OPTS}" ]; then - this should probably be kept consistent, and changed in both places, in a separate PR when this is in? I can raise one proposing that as a follow-up to this - if you would like?

rhuss · 2018-03-05T15:50:11Z

java/images/jboss/s2i/assemble

+
+  # ======================
+  # TODO Remove repo if desired
+#  if [ "x${MAVEN_CLEAR_REPO}" != "x" ]; then


Why commented out ?

I've un-commented it in the final clean-up commit now, using GRADLE_CLEAR_REPO and ${S2I_ARTIFACTS_DIR}/gradle, in anticipation of related future work under #150 ... OK?

jamesnetherton · 2018-03-09T07:20:17Z

If we are going to support Gradle then we should restrict its implementation to the community images initially.

dhirajsb · 2018-03-15T16:18:10Z

agree with @jamesnetherton

vorburger · 2018-04-18T11:51:20Z

@rhuss I'm hoping to be able to make time to pick this up after my other pending PRs are in; the idea would be to cover this using my new self testing approach for this example as well.

@jamesnetherton @dhirajsb sure OK for me initially community images only; so I'll put a big IFF into the respective templates - OK for you as well @rhuss ?

rhuss · 2018-04-29T06:50:43Z

@vorburger yes, sounds like a plan. I'm still a bit hesitant ans I'm not sure how good we can support the Gradle support in case of an error, but hey, let's try it ;-)

vorburger

@rhuss as per more detailed in-line comments, I've reacted to all of your review feedback.

@jamesnetherton @dhirajsb @rhuss the (hopefully) last commit in this PR restricts the implementation to the community image by a bunch of {{? fp.param.base != "rhel"}} in the template - OK for you?

vorburger · 2018-05-01T22:40:59Z

java/images/jboss/s2i/assemble

+
+  # Normalize dir
+  # TODO how do you get this to check not one but two (../..) up?
+#  dir=$(echo ${dir} | tr -s /)


it was inspired by the equivalent for Maven, but things work without this (as proven by java/examples/gradle in upcoming PR), so I've just removed in the new clean-up commit; hope that's OK? It could always be added back later (and covered by the example / test), if really needed.

vorburger · 2018-05-01T22:45:01Z

java/images/jboss/s2i/assemble

@@ -111,6 +136,10 @@ function setup_maven() {
  fi
 }

+function setup_gradle() {


Yup, sure, makes sense; so done now in new clean up commit. PS: Just for future reference, see Gradle doc re. proxies - this would have to do something like that, similarly to function setup_maven(), I guess.

vorburger · 2018-05-01T22:50:20Z

java/images/jboss/s2i/assemble

+  local gradle_args=${GRADLE_ARGS:-build -x test}
+
+  # If there is no user provided GRADLE_OPTS, use options from run-java.sh
+  if [ -f ${RUN_JAVA_DIR}/run-java.sh -a -z "${GRADLE_OPTS}" ]; then


Unfortunately my bash foo smartness is not nearly good enough 😃 to understand what exactly you mean here, but FYI I've just copy/pasted this from an almost identical line in build_maven() ... perhaps you would like to raise a follow-up PR, when this is in, to adjust both this and the original that I got inspired from for this however you see fit?

vorburger · 2018-05-01T22:52:30Z

java/images/jboss/s2i/assemble

+    export GRADLE_OPTS=$(${RUN_JAVA_DIR}/run-java.sh options)
+  fi
+
+  if [ ! -z "${GRADLE_OPTS}" ]; then


similarly to above, build_maven() uses if [ ! -z "${MAVEN_OPTS}" ]; then - this should probably be kept consistent, and changed in both places, in a separate PR when this is in? I can raise one proposing that as a follow-up to this - if you would like?

vorburger · 2018-05-01T23:03:13Z

java/images/jboss/s2i/assemble

+
+  # ======================
+  # TODO Remove repo if desired
+#  if [ "x${MAVEN_CLEAR_REPO}" != "x" ]; then


I've un-commented it in the final clean-up commit now, using GRADLE_CLEAR_REPO and ${S2I_ARTIFACTS_DIR}/gradle, in anticipation of related future work under #150 ... OK?

and mkdir -p it, because it can (and in our use case does) not exist, yet.

…mages#118)

rhuss

lgtm. Haven't really tested a gradel build, but I'm confident @vorburger will help us if there should be an issue.

BTW, @vorburger I added you with write access to this repo so that you then can work on and fix Gradle issues ;-P

vorburger · 2018-05-15T08:57:37Z

BTW, @vorburger I added you with write access to this repo so that you then can work on and fix Gradle issues ;-P

OK, cool - will do my best!

maslick · 2019-03-19T19:12:56Z

running s2i with -e GRADLE_CLEAR_REPO=true has no effect on the image size:

s2i build https://github.com/maslick/see-i-see-d.git#jdk11 fabric8/s2i-java:latest-java11 vesna:jdk11 -e GRADLE_CLEAR_REPO=true

I'm not sure but seems this if clause doesn't do anything:

# ======================
  # Remove repo if desired
  if [ "x${GRADLE_CLEAR_REPO}" != "x" ]; then
    rm -rf "${S2I_ARTIFACTS_DIR}/gradle"
    check_error "Cannot remove local Gradle repository ${S2I_ARTIFACTS_DIR}/gradle" $?
  fi

Instead it should have been:

if [ "x${GRADLE_CLEAR_REPO}" != "x" ]; then
    rm -rf "${S2I_SOURCE_DIR}"
    check_error "Cannot remove local Gradle repository ${S2I_SOURCE_DIR}" $?
  fi

rhuss · 2019-03-22T15:42:31Z

@vorburger could you please have a look ?

vorburger · 2019-04-10T16:23:50Z

@maslick sorry I don't really have the time to help with this project anymore, but if you'd like to raise a PR putting what you are suggesting above into code, then perhaps someone will help to review and merge it.

vorburger mentioned this pull request Mar 4, 2018

add support for Gradle builds in addition to Maven #118

Closed

rhuss reviewed Mar 5, 2018

View reviewed changes

vorburger mentioned this pull request Apr 10, 2018

mv java/example/ java/examples/maven/ #135

Merged

vorburger force-pushed the gradle branch from 63e900e to 75a07d7 Compare May 1, 2018 17:57

vorburger mentioned this pull request May 1, 2018

add support for incremental Gradle builds #150

Open

vorburger force-pushed the gradle branch from 75a07d7 to 20495fe Compare May 1, 2018 23:10

vorburger commented May 1, 2018

View reviewed changes

vorburger mentioned this pull request May 10, 2018

make Gradle run without its daemon #156

Closed

vorburger added 4 commits May 14, 2018 17:18

make DEPLOYMENTS_DIR overridable (fabric8io-images#146)

48902da

and mkdir -p it, because it can (and in our use case does) not exist, yet.

add Gradle build support, initial version (fixes fabric8io-images#118)

b77b0a8

clean up Gradle support (fabric8io-images#118)

d4c98e4

enable Gradle support only in community image, initially (fabric8io-i…

a0121b6

…mages#118)

rhuss force-pushed the gradle branch from ddda047 to a0121b6 Compare May 15, 2018 00:18

chore: Add binary flag for Gradle support

c0c1cfa

rhuss approved these changes May 15, 2018

View reviewed changes

rhuss merged commit 88da4d8 into fabric8io-images:master May 15, 2018

vorburger mentioned this pull request May 15, 2018

add Maven Wrapper support #152

Merged

vorburger mentioned this pull request Feb 13, 2019

RFE: Gradle support rh-openjdk/redhat-openjdk-containers#64

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Gradle build support, initial version (fixes #118) #121

add Gradle build support, initial version (fixes #118) #121

vorburger commented Mar 4, 2018

rhuss left a comment

rhuss Mar 5, 2018

vorburger May 1, 2018

rhuss Mar 5, 2018

vorburger May 1, 2018

rhuss Mar 5, 2018

vorburger May 1, 2018

rhuss Mar 5, 2018

vorburger May 1, 2018

rhuss Mar 5, 2018

vorburger May 1, 2018

jamesnetherton commented Mar 9, 2018

dhirajsb commented Mar 15, 2018

vorburger commented Apr 18, 2018

rhuss commented Apr 29, 2018

vorburger left a comment

vorburger May 1, 2018

vorburger May 1, 2018

vorburger May 1, 2018

vorburger May 1, 2018

vorburger May 1, 2018

rhuss left a comment

vorburger commented May 15, 2018

maslick commented Mar 19, 2019 •

edited

Loading

rhuss commented Mar 22, 2019

vorburger commented Apr 10, 2019

add Gradle build support, initial version (fixes #118) #121

add Gradle build support, initial version (fixes #118) #121

Conversation

vorburger commented Mar 4, 2018

rhuss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamesnetherton commented Mar 9, 2018

dhirajsb commented Mar 15, 2018

vorburger commented Apr 18, 2018

rhuss commented Apr 29, 2018

vorburger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhuss left a comment

Choose a reason for hiding this comment

vorburger commented May 15, 2018

maslick commented Mar 19, 2019 • edited Loading

rhuss commented Mar 22, 2019

vorburger commented Apr 10, 2019

maslick commented Mar 19, 2019 •

edited

Loading