Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv java/example/ java/examples/maven/ #135

Merged
merged 1 commit into from
May 14, 2018

Conversation

vorburger
Copy link
Collaborator

to make space for more examples, like "plain binaries",
or Dockerfile and upcoming Gradle based ones.

@vorburger
Copy link
Collaborator Author

@rhuss makes sense? When this is in, I'd like to contribute a "plain binaries" how-to example, and then amend #121 for #118 with a self testing example for that.

@vorburger
Copy link
Collaborator Author

This will conflict with #136, perhaps merge that one first, then I'll rebase and resolve the (trivial) conflict.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

to make space for more examples, like "plain binaries",
or Dockerfile and upcoming Gradle based ones.
@vorburger
Copy link
Collaborator Author

@rhuss rebased and conflict resolved - merge this now? Waiting for this to pick up #137 and #121 ...

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me

@rhuss rhuss merged commit 520e710 into fabric8io-images:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants