Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

홈 화면의 Tabbar를 정의해 보았습니다. #10

Merged
merged 7 commits into from
Jul 3, 2024
Merged

홈 화면의 Tabbar를 정의해 보았습니다. #10

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20cd42f
Feat: MainTabbar 정의
GeonH0 Jun 24, 2024
5cd2dd9
Fix: size 정의후 cornerRadius 선언 수정
GeonH0 Jun 25, 2024
eaa4f9c
Fix: 타이틀 폰트 사이즈 조절
GeonH0 Jun 25, 2024
087f6e1
Fix: guard문 수정
GeonH0 Jun 25, 2024
d76a2a2
Feat: addButton CGSize extension 정의
GeonH0 Jun 29, 2024
fc347c4
Fix: 버튼 사이즈 적용 및 버튼 size 네이밍 수정
GeonH0 Jun 29, 2024
3611d8b
Fix: Deafault 제거 후 Impl로 네이밍 변경
GeonH0 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions HomeCafeRecipes/HomeCafeRecipes/Presentation/Tabbar/MainTabBarController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import UIKit
class MainTabBarController: UITabBarController, UITabBarControllerDelegate {

private let addButton = UIButton(type: .custom)

private let buttonSize: CGFloat = 64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private let buttonSize: CGFloat = 64
private let buttonSize = CGSize(all: 64.0)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 네이밍에 맞춰서 부탁드리고, 버튼에 사이즈 넣어줄 때도 이 값을 사용하도록 수정부탁드려요.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5cd2dd9#diff-0d224758abc4ca45fc0282291d15c94cd69c91925cdfce32dd267ad65326baa0R61-R62 이부분이요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[d76a2a2],[fc347c4]
적용했습니다!


override func viewDidLoad() {
super.viewDidLoad()
self.delegate = self
Expand All @@ -23,7 +24,7 @@ class MainTabBarController: UITabBarController, UITabBarControllerDelegate {
addButton.backgroundColor = .blue
addButton.setTitle("+", for: .normal)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이틀 폰트 더 키울 수 있나요~? 스크린샷보니 좀 작아보여서요!

Copy link
Collaborator Author

@GeonH0 GeonH0 Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[eaa4f9c] 수정했습니다

addButton.setTitleColor(.white, for: .normal)
addButton.layer.cornerRadius = 32
addButton.layer.cornerRadius = buttonSize * 0.5
addButton.layer.shadowColor = UIColor.black.cgColor
addButton.layer.shadowOpacity = 0.3
addButton.layer.shadowOffset = CGSize(width: 0, height: 2)
Expand Down