홈 화면의 Tabbar를 정의해 보았습니다. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-barry
reviewed
Jun 24, 2024
|
|
||
| private func setupButton() { | ||
| addButton.backgroundColor = .blue | ||
| addButton.setTitle("+", for: .normal) |
There was a problem hiding this comment.
타이틀 폰트 더 키울 수 있나요~? 스크린샷보니 좀 작아보여서요!
| addButton.backgroundColor = .blue | ||
| addButton.setTitle("+", for: .normal) | ||
| addButton.setTitleColor(.white, for: .normal) | ||
| addButton.layer.cornerRadius = 32 |
There was a problem hiding this comment.
addButton의 size를 정의해두고 해당 사이즈의 height * 0.5를 해서 넣어주는건 어때요?
버튼 사이즈 따라가는게 안정적일 것 같아서요~
Comment on lines
35
to
39
| let networkService = DefaultRecipeFetchService(networkService: baseneworkServie) | ||
| let repository = DefaultFeedListRepository(networkService: networkService) | ||
| let searchrepository = DefaultSearchFeedRepository(networkService: networkService) | ||
| let fetchFeedListUseCase = DefaultFetchFeedListUseCase(repository: repository) | ||
| let searchFeedListUsecase = DefaultSearchFeedListUseCase(repository: searchrepository) |
There was a problem hiding this comment.
RecipeListViewController의 interactor를 주기 위해 넣었습니다
| @objc private func didTapActionButton() { | ||
| let alert = UIAlertController(title: "게시물 작성", message: "어떤 게시물을 작성하실 건가요?", preferredStyle: .actionSheet) | ||
| alert.addAction(UIAlertAction(title: "Coffee", style: .default, handler: { [weak self] _ in | ||
| guard let self = self else { return } |
There was a problem hiding this comment.
guard let self else { return } 로도 가능해요
GeonH0
force-pushed
the
feature/MainTabbarView
branch
from
c21f500 to
20cd42f
Compare
GeonH0
force-pushed
the
feature/MainTabbarView
branch
from
6b513d0 to
087f6e1
Compare
f-lab-barry
reviewed
Jun 28, 2024
| @@ -10,7 +10,8 @@ import UIKit | |||
| class MainTabBarController: UITabBarController, UITabBarControllerDelegate { | |||
|
|
|||
| private let addButton = UIButton(type: .custom) | |||
|
|
|||
| private let buttonSize: CGFloat = 64 | |||
There was a problem hiding this comment.
Suggested change
| private let buttonSize: CGFloat = 64 | |
| private let buttonSize = CGSize(all: 64.0) |
There was a problem hiding this comment.
size 네이밍에 맞춰서 부탁드리고, 버튼에 사이즈 넣어줄 때도 이 값을 사용하도록 수정부탁드려요.
There was a problem hiding this comment.
|
|
3611d8b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|
|
|