Further optimised palindrome-products solution (exercism#898) #1407
Conversation
|
@qianzhong516 I am a bit confused by this. #1398 is not merged yet so why not apply the improvements there directly? |
Sorry about that, because I realized I mixed with a few other previous merged commits in #1398... I wasn't sure if that would make the process more complicated when you guys merge the changes, that's why I restarted with a new branch then created a new pull request. Please let me know the better way to do it, so I will do accordingly next time :) |
There was a problem hiding this comment.
Approving this based on @joshgoebel s review here #1398
I also tested it and it works just as advertised, from 30s down to 1.5s. 🎉
junedev
added
hacktoberfest-accepted
Hi, this pull request is relate to #1398. I optimised more code based on dicussion with @joshgoebel. Thanks!