Skip to content

palindrome-products: optimise implementation #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SleeplessByte opened this issue Dec 18, 2020 · 2 comments · Fixed by #1407
Closed

palindrome-products: optimise implementation #898

SleeplessByte opened this issue Dec 18, 2020 · 2 comments · Fixed by #1407
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there good first issue

Comments

@SleeplessByte
Copy link
Member

Don't work on this issue until #895 is merged, or use that PR as a base branch.

The "largest palindrome from four digit factors" test currently takes > 30s to complete. When fixed, replace test.skip with xtest.
@SleeplessByte SleeplessByte added enhancement 🦄 Changing current behaviour, enhancing what's already there good first issue labels Dec 18, 2020
@tliebert
Copy link

This test case currently prevents the users code from passing the test suite - it returns this case as failed even though the test is skipped.

@junedev
Copy link
Member

junedev commented Sep 25, 2021

@tliebert Thanks for reporting. We are aware of the issue. @SleeplessByte is working on fixing this.

@SleeplessByte SleeplessByte mentioned this issue Oct 4, 2021
Closed
junedev pushed a commit that referenced this issue Oct 6, 2021
@qianzhong516
Optimised palindrome-products solution (#898) (#1407)
a4d02ba
@junedev junedev linked a pull request Oct 8, 2021 that will close this issue
Further optimised palindrome-products solution (exercism#898) #1407
Merged
@junedev junedev closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Further optimised palindrome-products solution (exercism#898)
3 participants
@SleeplessByte @junedev @tliebert