Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Enable a minimal theme option for simpler admonition style #106

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

mmcky
Copy link
Member

@mmcky mmcky commented Jul 2, 2024

This PR builds on top of #105 and enables a minimal theme for simpler admonition styling.

We had a lot of user feedback from our lecture sites that some of the admonitions were styled in a way that indicated a higher degree of importance than the surrounding text. In some cases that isn't always true (depending on the admonition type). It would be nice to have a way to visually identify the admonition without an overpowering styling.

This PR enables an option

proof_minimal_theme: True

that switches the proof.css styling to a simpler format. The option default is False.

Summary:

TODO:

  • review colours and remove any duplicates
  • add docs for switching the option on/off

@mmcky mmcky added the enhancement New feature or request label Jul 2, 2024
@mmcky mmcky marked this pull request as draft July 2, 2024 09:55
@mmcky mmcky marked this pull request as ready for review July 3, 2024 03:00
@mmcky mmcky requested a review from agoose77 July 3, 2024 03:04
@agoose77 agoose77 changed the base branch from main to maint-02jul July 3, 2024 08:55
@agoose77 agoose77 changed the base branch from maint-02jul to main July 3, 2024 08:55
@agoose77 agoose77 changed the base branch from main to maint-02jul July 3, 2024 08:58
@agoose77 agoose77 changed the base branch from maint-02jul to main July 3, 2024 08:59
@agoose77 agoose77 changed the base branch from main to maint-02jul July 3, 2024 09:03
@agoose77
Copy link
Contributor

agoose77 commented Jul 3, 2024

This looks good to me! I've changed the base branch to be #105. I think let's merge #105 (once we change the referencing logic), and then merge this into main directly after.

Base automatically changed from maint-02jul to main July 15, 2024 22:43
@mmcky mmcky merged commit 92f9008 into main Jul 15, 2024
7 checks passed
@mmcky mmcky deleted the review-theme branch July 15, 2024 22:49
mmcky added a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants