Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update to use remarks admonition once style is updated #442

Open
mmcky opened this issue May 9, 2024 · 3 comments
Open

MAINT: update to use remarks admonition once style is updated #442

mmcky opened this issue May 9, 2024 · 3 comments
Assignees

Comments

@mmcky
Copy link
Contributor

mmcky commented May 9, 2024

There are lectures such as #440 (comment)

that make use of remarks that could be nicely wrapped in admonitions, however the style is currently overly bold in sphinx-proof and gives too much weight to the contents.

Once executablebooks/sphinx-proof#98 is resolved we can loop through and add the admonitions to this lecture series.

@mmcky
Copy link
Contributor Author

mmcky commented Jun 30, 2024

@longye-tian would you have time today to review this issue and setup a PR that includes a remark admonition that we can use as a test case.

I will coordinate updates to the theme but it would be helpful to see how they look in a real work case.

longye-tian added a commit that referenced this issue Jul 1, 2024
Dear John,

This pull request is for #442.

I use the geom_series.md lecture as an example to test the current admonition style.

Best,
Longye
@mmcky
Copy link
Contributor Author

mmcky commented Jul 1, 2024

Started the process of updating sphinx-proof with a maintenance PR today.

executablebooks/sphinx-proof#99

Once that is accepted and merged we can then make progress on improvements to the style

@mmcky
Copy link
Contributor Author

mmcky commented Jul 2, 2024

This PR is now open

executablebooks/sphinx-proof#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants