Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Java Kafka client metrics via Producer/ConsumerMetrics #430

Merged
merged 9 commits into from
Jul 15, 2024
+363 −23
Merged

Abstract Java Kafka client metrics via Producer/ConsumerMetrics #430

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f447e9
Abstract Java Kafka client metrics via Producer/ConsumerMetrics
Jul 11, 2024
d8fe291
Calculate metrics prefix based on client ID
Jul 11, 2024
9655d6d
Update modules/metrics/src/main/scala/com/evolutiongaming/skafka/cons…
dfakhritdinov Jul 11, 2024
49467c0
Update modules/metrics/src/main/scala/com/evolutiongaming/skafka/cons…
dfakhritdinov Jul 11, 2024
1da4c59
Add docs, silent mima
Jul 11, 2024
eac1fdd
Re-implement java kafka metrics collection using registry, kudos to Z…
Jul 12, 2024
2c84391
Fix readme
Jul 12, 2024
2a454d5
make compatible with scala 2.12
Jul 12, 2024
3b47961
minor refactoring + fix docs
Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Update modules/metrics/src/main/scala/com/evolutiongaming/skafka/cons… 
…umer/ConsumerMetricsOf.scala

Co-authored-by: Mareks Rampāns <[email protected]>
@dfakhritdinov @mr-git
dfakhritdinov and mr-git authored Jul 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 49467c0600a5c722d10b6c187ab41bf5f68396da
3 changes: 2 additions & 1 deletion modules/metrics/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetricsOf.scala
View file
Original file line number Diff line number Diff line change
@@ -22,7 +22,8 @@ object ConsumerMetricsOf {
override def poll(topic: Topic, bytes: Int, records: Int, age: Option[FiniteDuration]): F[Unit] =
source.poll(topic, bytes, records, age)

override def count(name: String, topic: Topic): F[Unit] = source.count(name, topic)
override def count(name: String, topic: Topic): F[Unit] =
source.count(name, topic)

override def rebalance(name: String, topicPartition: TopicPartition): F[Unit] =
source.rebalance(name, topicPartition)