-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract Java Kafka client metrics via Producer/ConsumerMetrics #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9937634721Details
💛 - Coveralls |
Z1kkurat
reviewed
Jul 11, 2024
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerOf.scala
Show resolved
Hide resolved
mr-git
reviewed
Jul 11, 2024
modules/metrics/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetricsOf.scala
Outdated
Show resolved
Hide resolved
modules/metrics/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetricsOf.scala
Outdated
Show resolved
Hide resolved
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala
Show resolved
Hide resolved
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerOf.scala
Show resolved
Hide resolved
…umer/ConsumerMetricsOf.scala Co-authored-by: Mareks Rampāns <[email protected]>
…umer/ConsumerMetricsOf.scala Co-authored-by: Mareks Rampāns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses issue evolution-gaming/smetrics#237 and based on @Z1kkurat PR #324, thanks for inspiration!
Goal of the change is in exposing Java Kafka client metrics in the same way as native
skafka
metrics.Native metrics represented by
ProducerMetrics
andConsumerMetrics
traits, their implementation requirecom.evolutiongaming.smetrics.CollectorRegistry
. This approach allows decoupling metrics and their collector implementation, which is Prometheus (at leastsmetrics
provides Prometheus support, other implementations also possible).Java Kafka client metrics can be exposed to Prometheus with help of
com.evolutiongaming.skafka.metrics.KafkaMetricsCollector
- Prometheus collector was placed in separate module with dependency on Prometheus client. This PR aimed integrate the collector withProducerMetrics
andConsumerMetrics
traits in mainskafka
module (one without dependency on Prometheus client). For that new methods were introduced in both traits with default empty implementation. Actual implementation is in helper objectsProducerMetricsOf
andConsumerMetricsOf
respectively.Example: