Add ROS2 build test #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
force-pushed
the
pr-ros2-ci
branch
2 times, most recently
from
03db472
to
3b29395
Compare
Fix format Remove wstool Run with bash
Jaeyoung-Lim
force-pushed
the
pr-ros2-ci
branch
from
1c739b2
to
615d9e7
Compare
Ryanf55
reviewed
Dec 1, 2023
src/test_tif_loader.cpp
Outdated
There was a problem hiding this comment.
Did you mean to change the indent in this PR?
There was a problem hiding this comment.
Yes, that was part of a format fix. Are you using a different formatter than the one in this repo? (Tools)
| @@ -14,8 +15,9 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| config: | |||
| - {rosdistro: 'melodic', container: 'px4io/px4-dev-ros-melodic:2021-12-11'} | |||
| - {rosdistro: 'noetic', container: 'px4io/px4-dev-ros-noetic:2021-12-11'} | |||
| - {rosdistro: 'humble', container: 'osrf/ros:humble-desktop'} | |||
There was a problem hiding this comment.
If you only have one set in the matrix, I think just hard code these. Matrix like this will only work if humble, iron, and rolling have no difference. The more common pattern is to create a unique branch to manage each ROS version and then do all dev on rolling.
There was a problem hiding this comment.
I intended to test different ROS versions on the same branch. Can we keep it as is until we need different branches for different ROS releases?
Jaeyoung-Lim
force-pushed
the
pr-ros2-ci
branch
from
c5ffa85
to
3321f02
Compare
Ryanf55
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
This PR adds a build test CI using github actions for ros2
Fixes #29
@srmainwaring Would it make sense to add test for macOS as well?
@Ryanf55 Would you be able to review the PR? Not sure if this is the best way to build test a ROS 2 package :)
Additional context