Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Jaeyoung-Lim committed Dec 2, 2023
1 parent 615d9e7 commit 3321f02
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Build Test
on:
push:
branches:
# - 'master'
- 'ros2'
pull_request:
branches:
Expand All @@ -16,8 +15,6 @@ jobs:
matrix:
config:
- {rosdistro: 'humble', container: 'osrf/ros:humble-desktop'}
# - {rosdistro: 'melodic', container: 'px4io/px4-dev-ros-melodic:2021-12-11'}
# - {rosdistro: 'noetic', container: 'px4io/px4-dev-ros-noetic:2021-12-11'}
container: ${{ matrix.config.container }}
steps:
- uses: actions/checkout@v1
Expand All @@ -34,14 +31,13 @@ jobs:
working-directory:
run: |
mkdir -p $HOME/ros2_ws/src;
cd $HOME/ros2_ws
cd $HOME/ros2_ws/src
ln -s $GITHUB_WORKSPACE
cd $HOME/ros2_ws
source /opt/ros/humble/setup.bash
rosdep update
rosdep install --from-paths src --ignore-src -y --rosdistro ${{matrix.config.rosdistro}}
colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release -DCATKIN_ENABLE_TESTING=False --packages-up-to grid_map_geo
colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to grid_map_geo
shell: bash
# - name: unit_tests
# working-directory:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ rosdep install --from-paths src --ignore-src -y

Build the package
```
colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release -DCATKIN_ENABLE_TESTING=False --packages-up-to grid_map_geo
colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to grid_map_geo
```
## Running the package
The default launch file can be run as the following command.
Expand Down

0 comments on commit 3321f02

Please sign in to comment.