Increase the default number of rpc serving threads #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fairly confident that this solves the problem. Tacked it onto #376 and saw just 1/5 failed test runs ( |
|
It looks like the windows pipeline doesn't run all tests 😱 . I'm trying to address this in #403. |
This may be responsible for the timeouts on Windows CI, maybe clients aren't closing their connections in the same way? Anyway, it's a small enough change that it shouldn't wreck performance, and it's worth it to check if this fixes this pain in the butt CI issue.
carver
force-pushed
the
bigger-rpc-server-threadpool
branch
from
0c54a15 to
2c0c06d
Compare
|
Okay, as far as we can tell, this is reducing the flakiness. I think the best way to confirm this is to merge it aggressively, and confirm that it's not affecting PRs anymore. Rage-merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be responsible for the timeouts on Windows CI, maybe clients
aren't closing their connections in the same way?
Anyway, it's a small enough change that it shouldn't wreck performance,
and it's worth it to check if this fixes this pain in the butt CI issue.