Skip to content

Commit 2c0c06d

Browse files
committed
Increase the default number of rpc serving threads
This may be responsible for the timeouts on Windows CI, maybe clients aren't closing their connections in the same way? Anyway, it's a small enough change that it shouldn't wreck performance, and it's worth it to check if this fixes this pain in the butt CI issue.
1 parent fd91cea commit 2c0c06d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

trin-core/src/cli.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub struct TrinConfig {
4444
pub web3_ipc_path: String, // TODO: Change to PathBuf
4545

4646
#[structopt(
47-
default_value = "2",
47+
default_value = "5",
4848
long = "pool-size",
4949
help = "max size of threadpool"
5050
)]
@@ -121,7 +121,7 @@ impl Default for TrinConfig {
121121
web3_transport: "ipc".to_string(),
122122
web3_http_address: DEFAULT_WEB3_HTTP_ADDRESS.to_string(),
123123
web3_ipc_path: DEFAULT_WEB3_IPC_PATH.to_string(),
124-
pool_size: 2,
124+
pool_size: 5,
125125
discovery_port: DEFAULT_DISCOVERY_PORT.parse().unwrap(),
126126
bootnodes: vec![],
127127
external_addr: None,
@@ -259,7 +259,6 @@ mod test {
259259
TrinConfig::new_from(["trin", "--web3-transport", "ipc"].iter()).unwrap();
260260
let expected_config = TrinConfig {
261261
web3_http_address: DEFAULT_WEB3_HTTP_ADDRESS.to_string(),
262-
pool_size: 2,
263262
web3_transport: "ipc".to_string(),
264263
..Default::default()
265264
};
@@ -288,7 +287,6 @@ mod test {
288287
let expected_config = TrinConfig {
289288
web3_http_address: DEFAULT_WEB3_HTTP_ADDRESS.to_string(),
290289
web3_ipc_path: "/path/test.ipc".to_string(),
291-
pool_size: 2,
292290
web3_transport: "ipc".to_string(),
293291
..Default::default()
294292
};

0 commit comments

Comments
 (0)