Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to building GMP from an unofficial git mirror (CI hash update) #14768

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Switch to building GMP from an unofficial git mirror (CI hash update) #14768

merged 1 commit into from
Jan 5, 2024

Conversation

cameel
Copy link
Member

@cameel cameel commented Jan 5, 2024 •
edited
Loading

Depends on #14767 (should be merged together).

Note: I moved the ossfuzz job to the main workflow to test the image. This will be removed before the PR is merged. Done.

@cameel cameel added build system 🏗️ has dependencies The PR depends on other PRs that must be merged first labels Jan 5, 2024
@cameel cameel requested review from bshastry and aarlt January 5, 2024 12:24
@cameel cameel self-assigned this Jan 5, 2024
@cameel cameel force-pushed the fix-gmp-build-in-ossfuzz-docker-ci-update branch 2 times, most recently from 3fe395f to ccf656c Compare January 5, 2024 12:30
bshastry
bshastry requested changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@bshastry bshastry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes, fuzz test workflow needs to be moved back to nightly. Otherwise have one question?

.circleci/config.yml Outdated Show resolved Hide resolved
@cameel
Copy link
Member Author

cameel commented Jan 5, 2024

Looks like CI kinda passed. I.e. t_ubu_ossfuzz did fail like it does in nightly, but not because of anything GMP-related so I'm going to assume it's fine.

And brink failure is unrelated - standard ext test breakage. We can fix it separately.

So I'm removing the debug commit and making this reviewable.

@cameel cameel force-pushed the fix-gmp-build-in-ossfuzz-docker-ci-update branch from ccf656c to f4beac1 Compare January 5, 2024 13:44
@cameel cameel marked this pull request as ready for review January 5, 2024 13:44
@cameel cameel mentioned this pull request Jan 5, 2024
Merged
@cameel cameel requested a review from bshastry January 5, 2024 13:45
@cameel cameel force-pushed the fix-gmp-build-in-ossfuzz-docker-ci-update branch from f4beac1 to 469f285 Compare January 5, 2024 13:46
bshastry
bshastry previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@bshastry bshastry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Base automatically changed from fix-gmp-build-in-ossfuzz-docker to develop January 5, 2024 17:27
@cameel cameel dismissed bshastry’s stale review January 5, 2024 17:27

The base branch was changed.

@cameel cameel force-pushed the fix-gmp-build-in-ossfuzz-docker-ci-update branch from 469f285 to 5c79d5e Compare January 5, 2024 17:28
@cameel cameel enabled auto-merge January 5, 2024 17:28
@cameel cameel disabled auto-merge January 5, 2024 18:34
@cameel cameel merged commit 2348552 into develop Jan 5, 2024
63 of 64 checks passed
@cameel cameel deleted the fix-gmp-build-in-ossfuzz-docker-ci-update branch January 5, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshastry bshastry bshastry left review comments

@aarlt aarlt Awaiting requested review from aarlt

Assignees

@cameel cameel

Labels
build system 🏗️ has dependencies The PR depends on other PRs that must be merged first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameel @bshastry