Switch to building GMP from an unofficial git mirror #14767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
fix-gmp-build-in-ossfuzz-docker
branch
from
c38424d to
5fd52f3
Compare
|
|
Closed
bshastry
approved these changes
Jan 5, 2024
cameel
added
the
has dependencies
nikola-matic
reviewed
Jan 6, 2024
| test \ | ||
| "$(tar --create gmp/ --sort=name --mtime=1970-01-01Z --owner=0 --group=0 --numeric-owner | sha256sum)" = \ | ||
| "d606ff6a4ce98692f9920031e85ea8fcf4a65ce1426f6f0048b8794aefed174b -"; \ | ||
| # NOTE: This removes also libgmp.so, which git depends on |
There was a problem hiding this comment.
And also wget, and probably a ton of other stuff.
There was a problem hiding this comment.
Yeah, but git is relevant because we're using it a few lines above. The comment is there to explain why the removal of the installed GMP has to be done here and not before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #14760.
Note: This should not be merged without #14768.
This is just a minimal part of #14760 that's sufficient to fix the GMP build.
In the end I decided to submit this as a new PR rather than take over #14760. The original PR has some other unrelated changes (like evmone or cmake) and generally looks like it's just a messy branch meant to test things out rather to be merged (it's even called a "sandbox"). It also has some minor refactors and I'd actually like to add more (like switching to a build from Ubuntu sources or installing cmake from a package), but might require some discussion and we need the GMP fix soon, so I'm going to do all that in a separate PR.