Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FPS] multisig task tests #485

Merged
merged 80 commits into from
Jan 30, 2025
Merged
Changes from 1 commit
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
bea1a0a
remove: name and description from task config
ElliotFriedman Jan 22, 2025
ade894d
checkpoint
ElliotFriedman Jan 22, 2025
44dd5fd
remove isNested flag from toml config file
ElliotFriedman Jan 22, 2025
40b6f9e
fmt
ElliotFriedman Jan 23, 2025
43acb05
fix is nested safe logic
prat-gpt Jan 23, 2025
c3e4c4b
fix task01
prat-gpt Jan 23, 2025
237a015
add Task02
prat-gpt Jan 23, 2025
8e94d13
refactor _getDataToSign function
ElliotFriedman Jan 23, 2025
f8aed6d
add: gas template docs
ElliotFriedman Jan 23, 2025
5fe7914
Merge branch 'feat/templates-pt2' of github.com:solidity-labs-io/supe…
ElliotFriedman Jan 23, 2025
15b2f60
add: template examples to run
ElliotFriedman Jan 23, 2025
bd58ec5
add: error handle parsing l2 chain configs
ElliotFriedman Jan 23, 2025
e76e57a
fmt
ElliotFriedman Jan 23, 2025
6a5bda5
remove unused variable name
ElliotFriedman Jan 23, 2025
f15022d
error handle reading in and parsing task config file
ElliotFriedman Jan 23, 2025
a06ef46
Merge branch 'main' into feat/templates-pt2
ElliotFriedman Jan 23, 2025
4391957
add breakdown of calldata difference for signers
ElliotFriedman Jan 23, 2025
cd28019
remove setting scalars to simplify example task
ElliotFriedman Jan 23, 2025
01ff9d7
add duplicate call structure of task 020 in existing tooling
ElliotFriedman Jan 23, 2025
d5fe386
remove setting gas scalars from gas config template
ElliotFriedman Jan 23, 2025
86921e4
Merge branch 'feat/templates-pt2' of github.com:solidity-labs-io/supe…
ElliotFriedman Jan 23, 2025
b81fb94
note on commenting out failing check and link to diffchecker
ElliotFriedman Jan 23, 2025
50717d1
add: task config tests
ElliotFriedman Jan 23, 2025
4a35d70
add forge build before running template
ElliotFriedman Jan 23, 2025
68b518b
update docs to only include gas limits and not gas scalars
ElliotFriedman Jan 23, 2025
1088348
remove template ci runs
ElliotFriedman Jan 23, 2025
27d04c9
Update src/fps/FPS.md
ElliotFriedman Jan 23, 2025
c6c2b50
Update src/fps/FPS.md
ElliotFriedman Jan 23, 2025
d5acbb9
Update src/fps/FPS.md
ElliotFriedman Jan 23, 2025
dd997ca
fps -> new task simulation tooling
ElliotFriedman Jan 23, 2025
9d9b268
Merge branch 'feat/templates-pt2' of github.com:solidity-labs-io/supe…
ElliotFriedman Jan 23, 2025
0fa2661
remove unused template files
ElliotFriedman Jan 23, 2025
80cb410
naming: fps.md -> readme.md
ElliotFriedman Jan 23, 2025
403c040
naming: move away from fps
ElliotFriedman Jan 23, 2025
1c9633c
use op types, remove inlined interfaces
ElliotFriedman Jan 23, 2025
6150e4d
update readme for running tasks
ElliotFriedman Jan 23, 2025
b8bef6e
update: cleanup, make MultisigTask a generic template
ElliotFriedman Jan 23, 2025
803b84a
fix test
ElliotFriedman Jan 24, 2025
8b8c1de
delete: task config
ElliotFriedman Jan 24, 2025
155eae4
update based on PR feedback, remove taskConfig.toml fields, and safeN…
ElliotFriedman Jan 24, 2025
b49165d
remove unused mock network configs
ElliotFriedman Jan 24, 2025
e235404
remove opmainnetConfig.toml
ElliotFriedman Jan 24, 2025
3f8b5fc
add op set gas limit config
ElliotFriedman Jan 24, 2025
0cf2842
update command to use new run function
ElliotFriedman Jan 24, 2025
6027c6b
update command to only have mainnet config toml file
ElliotFriedman Jan 24, 2025
e6c80c2
naming: networkConfigFilePath -> taskConfigFilePath
ElliotFriedman Jan 24, 2025
9d77704
fmt
ElliotFriedman Jan 24, 2025
cf51481
natspec, taskStorageWrites -> _taskStorageWrites
ElliotFriedman Jan 24, 2025
51e74b9
fix test
ElliotFriedman Jan 24, 2025
92c88f4
add additional docs for address registry
ElliotFriedman Jan 24, 2025
e901161
fix: nested multisig issue
ElliotFriedman Jan 24, 2025
0ecdca5
add op gas config command
ElliotFriedman Jan 24, 2025
70ed74f
add task tests
prat-gpt Jan 24, 2025
152b2d3
Revert "add task tests"
prat-gpt Jan 24, 2025
4ffc20f
add tests
prat-gpt Jan 24, 2025
68fe293
fix: nonce for nested safes use their own nonce and not parent
ElliotFriedman Jan 24, 2025
6f58ac7
Merge branch 'feat/templates-pt2' of github.com:solidity-labs-io/supe…
ElliotFriedman Jan 24, 2025
4645579
Merge branch 'main' into feat/templates-pt2
ElliotFriedman Jan 24, 2025
9cc89d6
update natspec proposal -> task
ElliotFriedman Jan 24, 2025
512f631
Merge branch 'main' into feat/templates-pt2
ElliotFriedman Jan 26, 2025
32d5528
fix failing single multisig tests
prat-gpt Jan 27, 2025
abf0bda
cleanup debug logs
prat-gpt Jan 27, 2025
2230855
fix address registry failing test
prat-gpt Jan 27, 2025
089a57d
Merge branch 'feat/templates-pt2' into feat/task-test
prat-gpt Jan 27, 2025
daa5186
add test for nested hash to approve
prat-gpt Jan 27, 2025
7194585
rename public function
prat-gpt Jan 27, 2025
cb196c2
remove build warnings
prat-gpt Jan 27, 2025
5cf515f
pr feedback
prat-gpt Jan 27, 2025
4e5a5c1
Merge branch 'upstream-main' into feat/task-test
prat-gpt Jan 27, 2025
cf29738
Update src/fps/task/MultisigTask.sol
prateek105 Jan 28, 2025
76fda92
pr feedback
prat-gpt Jan 29, 2025
c4bbe47
fix: virtual keyword to allow template variants
blmalone Jan 29, 2025
0d10d73
Merge pull request #25 from solidity-labs-io/bm/refactor-virtual-keyw…
blmalone Jan 29, 2025
bcdc5fa
Merge branch 'main' into feat/task-test
ElliotFriedman Jan 29, 2025
de66ddf
address pr feedback: multicall import
ElliotFriedman Jan 29, 2025
05be9d5
delete testnetConfig.toml
ElliotFriedman Jan 29, 2025
d4ecfb6
add: natspec comment on taskConfigFilePath var
ElliotFriedman Jan 29, 2025
656de62
address feedback: add comments
ElliotFriedman Jan 30, 2025
eccb3ae
Merge branch 'main' into feat/task-test
blmalone Jan 30, 2025
91b99f9
Merge branch 'main' into feat/task-test
ElliotFriedman Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove opmainnetConfig.toml
Signed-off-by: Elliot <[email protected]>
ElliotFriedman committed Jan 24, 2025

Verified

This commit was signed with the committer’s verified signature.
commit e23540413a1e0b235d2a40e02df89f597673b0fd
6 changes: 0 additions & 6 deletions src/fps/example/task-00/opmainnetConfig.toml

This file was deleted.