[FPS] multisig task tests

[prateek105]

Description
Add tests for Single and Nested Multisig Tasks.

Tests

Additional context
Using GasConfigTemplate for Single multisig tests and DisputeGameUpgradeTemplate for nested multisig tests

Metadata

[blmalone]

I don't think we need test/registry/.gitkeep in this PR.

Made a first pass through this. Still need to go through SingleMultisig.t.sol.

[blmalone]

few more comments

[blmalone]

This is correct right?

Suggested change

	/// the child multisig which does not increment the nonce
	/// the child multisig owners which does not increment the nonce

[ElliotFriedman]

I don't think we call as the child multisig owners, we just prank as the child multisigs currently

[blmalone]

Can we import this from IMultiCall3.sol in. import {IMulticall3} from "forge-std/interfaces/IMulticall3.sol";?

[ElliotFriedman]

done

[blmalone]

Same as comment below can we take this from import {IMulticall3} from "forge-std/interfaces/IMulticall3.sol";?

[ElliotFriedman]

done

[blmalone]

Suggested change

	string taskConfigFilePath = "src/fps/example/task-00/mainnetConfig.toml";
	/// ProxyAdminOwner safe for task-00 is a single multisig.
	string taskConfigFilePath = "src/fps/example/task-00/mainnetConfig.toml";

[ElliotFriedman]

done

[blmalone]

I don't believe src/fps/example/task-00/testnetConfig.toml is used anywhere, can we delete this as part of this PR?

[ElliotFriedman]

done

[blmalone]

Suggested change

	bytes memory expectedDataToSign = IGnosisSafe(multisigTask.multisig()).encodeTransactionData({
	/// The nonce is decremented by 1 because we want to recreate the data to sign with the same nonce
	/// that was used in the simulation. The nonce was incremented as part of running the simulation.
	bytes memory expectedDataToSign = IGnosisSafe(multisigTask.multisig()).encodeTransactionData({

[blmalone]

I'm thinking that we can cut a lot of code down in these IncorrectGasConfigTemplate*files by making the relevant functions inside GasConfigTemplate vitrual. e.g.

contract A {
    function foo() internal pure virtual returns (string[] memory);
}

contract B is A {
    function foo() internal pure virtual override returns (string[] memory) {
        // Using virtual twice like this, what do people think?
    }
}

contract C is B {
    function foo() internal pure override returns (string[] memory) {
        // Further override
    }
}

IncorrectGasConfigTemplate*.sol would become:

pragma solidity 0.8.15;

import {SystemConfig} from "@eth-optimism-bedrock/src/L1/SystemConfig.sol";

import {GasConfigTemplate} from "src/fps/example/template/GasConfigTemplate.sol";
import {AddressRegistry as Addresses} from "src/fps/AddressRegistry.sol";

/// @title IncorrectGasConfigTemplate2
/// @notice not all allowed storages writes are written to
contract IncorrectGasConfigTemplate2 is GasConfigTemplate {
    function _taskStorageWrites() internal pure override returns (string[] memory) {
        string[] memory storageWrites = new string[](2);
        /// expected to be written to
        storageWrites[0] = "SystemConfigOwner";
        storageWrites[1] = "SystemConfigProxy";
        return storageWrites;
    }
}

pragma solidity 0.8.15;

import {SystemConfig} from "@eth-optimism-bedrock/src/L1/SystemConfig.sol";

import {GasConfigTemplate} from "src/fps/example/template/GasConfigTemplate.sol";
import {AddressRegistry as Addresses} from "src/fps/AddressRegistry.sol";

/// @title IncorrectGasConfigTemplate1
/// @notice allowed storage write to incorrect address
contract IncorrectGasConfigTemplate1 is GasConfigTemplate {
    function _taskStorageWrites() internal pure override returns (string[] memory) {
        string[] memory storageWrites = new string[](1);
        /// wrong address
        storageWrites[0] = "SystemConfigOwner";
        return storageWrites;
    }
}

[ElliotFriedman]

looks like this is resolved now