Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for release 0.3.0 #27

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Preparation for release 0.3.0 #27

wants to merge 19 commits into from

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 17, 2024

No description provided.

@RMeli RMeli self-assigned this Dec 17, 2024
@RMeli RMeli added release spack Spack package labels Dec 17, 2024
RMeli
RMeli commented Dec 17, 2024
View reviewed changes
CITATION.cff
version: 0.2.0
date-released: '2024-07-05'
version: 0.3.0
date-released: '2024-12-17'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update date to release day.

rasolca
rasolca reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@rasolca rasolca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT:
We might have a problem!
I noticed now that il and iu for the ScaLAPACK partial spectrum are handled differently in C-API and Fortran API:
IMO this should be the correct behaviour:
DLAF-C -> il and iu base 0
DLAF-SCALAPACK-C and DLAF-SCALAPACK-FORTRAN -> base 1
(Otherwise DLAF-SCALAPACK-C is not a "almost drop-in" replacement to scalapack).
@RMeli @msimberg What do you think?
Correcting this problem might need a 0.7.2 patch release and a deprecation of 0.7.0 and 0.7.1, to avoid mess in DLAF-Fortran in the future.

This was referenced Dec 19, 2024
Merged
Merged
@RMeli RMeli force-pushed the pre-release-0.3.0 branch from a50f19d to c4f0211 Compare December 19, 2024 14:26
@RMeli
Copy link
Member Author

RMeli commented Dec 19, 2024

Issue raised by @rasolca fixed in DLA-Future by eth-cscs/DLA-Future#1248 and in DLA-Future-Fortran by #28. This PR is now blocked by DLA-Future release 0.7.2.

@RMeli RMeli marked this pull request as draft December 19, 2024 14:27
RMeli
RMeli commented Dec 19, 2024
View reviewed changes
ci/ci-common.yml Outdated Show resolved Hide resolved
RMeli
RMeli commented Dec 19, 2024
View reviewed changes
ci/docker/common.yaml Outdated Show resolved Hide resolved
spack/packages/dla-future-fortran/package.py Outdated Show resolved Hide resolved
RMeli
RMeli commented Dec 20, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
RMeli
RMeli commented Dec 20, 2024
View reviewed changes
RELEASE_PROCEDURE.md Outdated Show resolved Hide resolved
RMeli
RMeli commented Dec 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
RMeli
RMeli commented Dec 20, 2024
View reviewed changes
RELEASE_PROCEDURE.md Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be changed according to eth-cscs/DLA-Future#1250

RMeli
RMeli commented Dec 20, 2024
View reviewed changes
ci/docker/common.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasolca rasolca rasolca left review comments

@msimberg msimberg msimberg approved these changes

@albestro albestro Awaiting requested review from albestro

Assignees

@RMeli RMeli

Labels
release spack Spack package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RMeli @msimberg @rasolca