Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hmm.py, make the window paramter activate of segment_hmm function #835

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

zhuying412
Copy link
Contributor

@zhuying412 zhuying412 commented Aug 1, 2023

make the window paramter activate of segment_hmm function
#833

make the window paramter activate of segment_hmm function
@etal
Copy link
Owner

etal commented Aug 11, 2023

Thanks, @Zhu-ying . Was this change enough to fix the false negative you saw in #833 ? Did it improve your results overall, and not cause any other false positives or negatives elsewhere?

@zhuying412
Copy link
Contributor Author

zhuying412 commented Aug 15, 2023

Thanks, @Zhu-ying . Was this change enough to fix the false negative you saw in #833 ? Did it improve your results overall, and not cause any other false positives or negatives elsewhere?

Yes, if I set the window=2, I can get more CNVs which is smaller size,and the false negative CNV can be called. the window
is larger, the sensitivity is lower. I don't know why, but it works. I think it will produce some false positives, but we need lower false negatives in clincal. we just want to make the -t (threshold/window) parameter actived,now the code is commented.

@etal etal merged commit 3749aae into etal:master Aug 15, 2023
0 of 6 checks passed
@etal
Copy link
Owner

etal commented Aug 15, 2023

Great, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants