Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.lua #30

Closed
wants to merge 1 commit into from
Closed

Update main.lua #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ RegisterNetEvent('esx_banking:closebanking', function()
BANK:HandleUi(false)
end)

RegisterNetEvent('esx_banking:pedHandler', function(netIdTable)
RegisterNetEvent('esx_banking:PedHandler', function(netIdTable)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn’t make sense to use Pascal case really. plus always a chance resources have built on this event. could cause a few issues for essentially a pointless change in my opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AddEventHandler('esx:playerLoaded', function(playerId)
TriggerClientEvent('esx_banking:pedHandler', playerId, netIdTable)
end)

TriggerClientEvent('esx_banking:PedHandler', -1, netIdTable)

I look at it and we have this two TriggerClientEvent on server side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i guess it will be better to change pedHandler event on server side :D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I didn't saw it. Thank you.

for i = 1, #netIdTable do
BANK:LoadNpc(i, netIdTable[i])
end
Expand Down