Update main.lua #30
Closed
Update main.lua #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small mistake with the event name.
Cyzxin
reviewed
Jul 17, 2023
| @@ -181,7 +181,7 @@ RegisterNetEvent('esx_banking:closebanking', function() | |||
| BANK:HandleUi(false) | |||
| end) | |||
|
|
|||
| RegisterNetEvent('esx_banking:pedHandler', function(netIdTable) | |||
| RegisterNetEvent('esx_banking:PedHandler', function(netIdTable) | |||
There was a problem hiding this comment.
doesn’t make sense to use Pascal case really. plus always a chance resources have built on this event. could cause a few issues for essentially a pointless change in my opinion.
There was a problem hiding this comment.
AddEventHandler('esx:playerLoaded', function(playerId)
TriggerClientEvent('esx_banking:pedHandler', playerId, netIdTable)
end)
TriggerClientEvent('esx_banking:PedHandler', -1, netIdTable)
I look at it and we have this two TriggerClientEvent on server side.
There was a problem hiding this comment.
So i guess it will be better to change pedHandler event on server side :D
There was a problem hiding this comment.
Okay, I didn't saw it. Thank you.
|
Fixed in this commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small mistake with the event name.