Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(usb_host): Class drivers test apps run on esp32p4 #85

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky commented Nov 8, 2024

Description

This MR enables class drivers test apps, to be run on esp32p4

Changes

  • New esp32p4 usb_host target runner BrnoVM0114 was added to the CI
  • Enabled test apps build and run in CI for esp32p4
  • Memory leak checks evaluation during test case teardown updated to new API
  • removed all code in test apps related to IDF versions lower than 5.0
  • usb_host_lib_set_root_port_power function used to toggle connection of USB devices must be used for esp32p4, but has been implemented only in IDF 5.2
    • for IDF versions lower than 5.3, the old way of connection toggling (using PHY) is used, because esp32p4 has been added from IDF 5.3
    • for IDF versions higher than, including 5.3, the new way of connection toggling (using root power) is used.

Related

  • RDT-995 Add new esp32p4 usb_host runner
  • IDF-11346 Build USB P4 runners for GitHub
  • IDF-11685 Run esp-usb class driver tests in CI on esp32p4
  • Follow up: Enable target run for esp32p4 on IDF 5.3 once the IDF 5.3 docker image is updated

Testing

  • CDC-ACM, HID, MSC, UVC class driver tests are passing locally on a reproduced CI target runner setup
  • UAC class driver not modified, since it's not being run in any CI tests

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky peter-marcisovsky self-assigned this Nov 8, 2024
@peter-marcisovsky
Copy link
Collaborator Author

CI build failed: usb_host_lib_set_root_port_power function used for trigger connection/disconnection in target tests not present in IDF 5.0 and IDF 5.1

@peter-marcisovsky peter-marcisovsky force-pushed the ci/run_p4_class_driver_tests branch from 03ec3f0 to b415c65 Compare November 11, 2024 11:07
@peter-marcisovsky peter-marcisovsky changed the title Class drivers test apps run on esp32p4 ci(usb_host): Class drivers test apps run on esp32p4 Nov 11, 2024
@peter-marcisovsky
Copy link
Collaborator Author

CI tests passed on the current esp32s2 target runners, waiting for the new esp32p4 target runners to be build and the CI tests to be run on them.

@peter-marcisovsky peter-marcisovsky force-pushed the ci/run_p4_class_driver_tests branch 2 times, most recently from d6446da to 9792629 Compare November 15, 2024 10:24
@tore-espressif tore-espressif force-pushed the ci/run_p4_class_driver_tests branch from fd8456a to 8da2f06 Compare December 2, 2024 10:22
@tore-espressif
Copy link
Collaborator

@peter-marcisovsky The P4 tests passed, thank you!

The failure on release/v5.3 should be already fixed. We must wait for new release/v5.3 docker image release (or ignore the 5.3 tests for now)

@peter-marcisovsky peter-marcisovsky marked this pull request as ready for review December 2, 2024 14:11
@peter-marcisovsky peter-marcisovsky force-pushed the ci/run_p4_class_driver_tests branch from db0d623 to d81cf74 Compare December 2, 2024 14:18
    - Enabled drivers CDC-ACM, HID, MSC, UVC
    - Added new usb_host esp32p4 CI runner
@peter-marcisovsky peter-marcisovsky force-pushed the ci/run_p4_class_driver_tests branch from 23ee629 to 998b6f5 Compare December 2, 2024 18:14
@peter-marcisovsky peter-marcisovsky merged commit 3979c8f into master Dec 2, 2024
27 checks passed
@peter-marcisovsky peter-marcisovsky deleted the ci/run_p4_class_driver_tests branch December 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants