Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Clean up pytest global configuration user warnings #443

Merged
merged 1 commit into from
Feb 6, 2024
Merged

CLN: Clean up pytest global configuration user warnings #443

merged 1 commit into from
Feb 6, 2024

Conversation

janbjorge
Copy link
Contributor

@janbjorge janbjorge commented Jan 31, 2024

Still a few warnings left (3), they need more effort. Want to merge this first to limit dev. noise.

@janbjorge janbjorge self-assigned this Jan 31, 2024
@janbjorge janbjorge marked this pull request as ready for review February 6, 2024 12:41
@janbjorge janbjorge requested review from mferrera, jcrivenaes and perolavsvendsen and removed request for mferrera February 6, 2024 12:41
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed an early return statement, see comment. This looks like a nice improvement 👍

tests/test_units/test_dataio.py Outdated Show resolved Hide resolved
@@ -181,70 +182,62 @@ def fixture_casesetup(tmp_path_factory):
return tmppath


@pytest.fixture(name="caseglobalconfig", scope="module")
def fixture_caseglobalconfig():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused.

@janbjorge janbjorge merged commit 4516486 into equinor:main Feb 6, 2024
12 checks passed
@janbjorge janbjorge deleted the cleanup-pytest-global-conf-warnings branch February 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants