ENH: Graceful metadata validation #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
commented
Feb 6, 2024
janbjorge
requested review from
mferrera,
jcrivenaes,
rwiker and
perolavsvendsen
and removed request for
mferrera
jcrivenaes
reviewed
Feb 7, 2024
jcrivenaes
reviewed
Feb 7, 2024
jcrivenaes
approved these changes
Feb 7, 2024
Had a talk with Per, there is no other values stored in sumo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if graceful will be the right term here, any content that is not part of the schema will be dropped. However, if there is types or structures that are not according to the model validation fails and we fallback the to original object.
Related to: #440