Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include time zone offset in tracklog datetime. #398

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fmu/dataio/_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def generate_meta_tracklog() -> list:
"""Create the tracklog metadata, which here assumes 'created' only."""
meta = list()

dtime = datetime.datetime.now().isoformat()
dtime = datetime.datetime.now().astimezone().isoformat()
user = getpass.getuser()
meta.append({"datetime": dtime, "user": {"id": user}, "event": "created"})
return meta
Expand Down
23 changes: 23 additions & 0 deletions tests/test_units/test_metadata_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
import logging
from copy import deepcopy

from dateutil.parser import isoparse

import pytest

import fmu.dataio as dio
Expand All @@ -27,6 +29,27 @@ def test_metadata_dollars(edataobj1):
assert mymeta.meta_dollars["source"] == SOURCE


# --------------------------------------------------------------------------------------
# Tracklog
# --------------------------------------------------------------------------------------


def test_generate_meta_tracklog(edataobj1):
mymeta = _MetaData("dummy", edataobj1)
mymeta._populate_meta_tracklog()
tracklog = mymeta.meta_tracklog

assert isinstance(tracklog, list) and len(tracklog) == 1 # assume "created"

logentry = tracklog[0]
assert "event" in logentry and logentry["event"] == "created"
assert "user" in logentry and "id" in logentry["user"]
assert "datetime" in logentry

# datetime in tracklog shall include time zone offset
assert isoparse(logentry["datetime"]).tzinfo is not None


# --------------------------------------------------------------------------------------
# DATA block (ObjectData)
# --------------------------------------------------------------------------------------
Expand Down
Loading