Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include time zone offset in tracklog datetime. #398

Merged

Conversation

perolavsvendsen
Copy link
Member

@perolavsvendsen perolavsvendsen commented Dec 14, 2023

Solve #397

This PR adds (local) time zone offset to the datetime in tracklog.
E.g. 2023-12-14T15:22:45.729902 -> 2023-12-14T15:22:45.729902+01:00

Issue states "ZULU" time. In this PR, I have deliberately chosen to implement local time instead. I figure that the most important element here is to include time zone offset. I don't currently have full overview of what possible confusion we could risk if these time stamps are not on local time.

Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perolavsvendsen perolavsvendsen merged commit 49d709e into equinor:main Dec 15, 2023
9 checks passed
@perolavsvendsen perolavsvendsen deleted the 397-tracklog-zulu-time branch December 15, 2023 11:11
@perolavsvendsen perolavsvendsen restored the 397-tracklog-zulu-time branch December 15, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants