Raise when duplicate GEN_KW keys

src/ert/config/gen_kw_config.py

@@ -8,7 +8,7 @@
 from dataclasses import dataclass
 from hashlib import sha256
 from pathlib import Path
 from typing import TYPE_CHECKING, Callable, Dict, List, Optional, TypedDict, overload
 
 import numpy as np
 import pandas as pd
@@ -120,7 +120,7 @@
         if init_file and "%" not in init_file:
             errors.append(
                 ConfigValidationError.with_context(
                     "Loading GEN_KW from files requires %d in file format", gen_kw
                 )
             )
         if errors:
@@ -145,7 +145,7 @@
     def _validate(self) -> None:
         errors = []
 
         def _check_non_negative_parameter(param: str, prior: PriorDict) -> None:
             key = prior["key"]
             dist = prior["function"]
             param_val = prior["parameters"][param]
@@ -157,7 +157,17 @@
                     ).set_context(self.name)
                 )
 
+        unique_keys = set()
         for prior in self.get_priors():
+            key = prior["key"]
+            if key in unique_keys:
+                errors.append(
+                    ErrorInfo(
+                        f"Duplicate GEN_KW keys {key!r} found, keys must be unique."
+                    ).set_context(self.name)
+                )
+            unique_keys.add(key)
+
             if prior["function"] == "LOGNORMAL":
                 _check_non_negative_parameter("MEAN", prior)
                 _check_non_negative_parameter("STD", prior)
@@ -172,7 +182,7 @@
         if self.forward_init_file:
             return self.read_from_runpath(Path(), real_nr)
 
         logging.info(f"Sampling parameter {self.name} for realization {real_nr}")
         keys = [e.name for e in self.transfer_functions]
         parameter_value = self._sample_value(
             self.name,
@@ -185,7 +195,7 @@
         return xr.Dataset(
             {
                 "values": ("names", parameter_value),
                 "transformed_values": ("names", self.transform(parameter_value)),
                 "names": keys,
             }
         )
@@ -197,7 +207,7 @@
     ) -> xr.Dataset:
         keys = [e.name for e in self.transfer_functions]
         if not self.forward_init_file:
             raise ValueError("loading gen_kw values requires forward_init_file")
 
         parameter_value = self._values_from_file(
             real_nr,
@@ -208,7 +218,7 @@
         return xr.Dataset(
             {
                 "values": ("names", parameter_value),
                 "transformed_values": ("names", self.transform(parameter_value)),
                 "names": keys,
             }
         )
@@ -216,11 +226,11 @@
     def write_to_runpath(
         self, run_path: Path, real_nr: int, ensemble: EnsembleReader
     ) -> Dict[str, Dict[str, float]]:
         array = ensemble.load_parameters(self.name, real_nr, var="transformed_values")
         if not array.size == len(self.transfer_functions):
             raise ValueError(
                 f"The configuration of GEN_KW parameter {self.name}"
                 f" is of size {len(self.transfer_functions)}, expected {array.size}"
             )
 
         data = dict(zip(array["names"].values.tolist(), array.values.tolist()))

tests/unit_tests/config/test_gen_kw_config.py

@@ -34,6 +34,26 @@ def test_gen_kw_config():
     assert len(conf.transfer_functions) == 3
 
 
+@pytest.mark.usefixtures("use_tmpdir")
+def test_gen_kw_config_duplicate_keys_raises():
+    with pytest.raises(
+        ConfigValidationError,
+        match="Duplicate GEN_KW keys 'KEY2' found, keys must be unique.",
+    ):
+        GenKwConfig(
+            name="KEY",
+            forward_init=False,
+            template_file="",
+            transfer_function_definitions=[
+                "KEY1 UNIFORM 0 1",
+                "KEY2 UNIFORM 0 1",
+                "KEY2 UNIFORM 0 1",
+                "KEY3 UNIFORM 0 1",
+            ],
+            output_file="kw.txt",
+        )
+
+
 @pytest.mark.usefixtures("use_tmpdir")
 def test_gen_kw_config_get_priors():
     parameter_file = "parameters.txt"