Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise when duplicate GEN_KW keys #6109

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 19, 2023

Issue
Resolves #6074

Approach
Verifies that GEN_KW keys are unique

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Sep 19, 2023
@andreas-el andreas-el self-assigned this Sep 19, 2023
@andreas-el andreas-el changed the title Fix duplicate gen kw ids Raise when duplicate GEN_KW keys Sep 19, 2023
@andreas-el andreas-el force-pushed the fix_duplicate_gen_kw_ids branch 2 times, most recently from 09b14aa to 94674da Compare September 19, 2023 11:08
Report duplicate GEN_KW keys encountered
Add GEN_KW duplicate key test
@codecov-commenter
Copy link

Codecov Report

Merging #6109 (b9007a8) into main (d1ae20d) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6109   +/-   ##
=======================================
  Coverage   82.48%   82.49%           
=======================================
  Files         350      350           
  Lines       21486    21491    +5     
  Branches      826      826           
=======================================
+ Hits        17723    17728    +5     
  Misses       3469     3469           
  Partials      294      294           
Files Changed Coverage Δ
src/ert/config/gen_kw_config.py 98.07% <100.00%> (+0.03%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍍

@andreas-el andreas-el merged commit 5f097a8 into equinor:main Sep 19, 2023
41 checks passed
@andreas-el andreas-el deleted the fix_duplicate_gen_kw_ids branch September 19, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when clicking Create Plot after running experiment with non-unique prior IDs
3 participants