Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin setuptools #6089

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/doctest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
fail-fast: false
steps:
- uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
id: setup_python
Expand All @@ -31,6 +32,13 @@ jobs:
setup.py
pyproject.toml
dev-requirements.txt

- name: Create and activate virtual environment
run: |
python -m venv .venv
. .venv/bin/activate
echo PATH=$PATH >> $GITHUB_ENV

- run: pip install -e .

- name: Install with dependencies
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[build-system]

requires = [
"setuptools<64",
"setuptools",
"setuptools_scm[toml]>=6.2",
"wheel",
"scikit-build",
"cmake",
"ninja",
"ecl",
"conan<2",
"ecl",
"pybind11>=2.10.0", # If this comes out of sync with the version installed by Conan please update the version in CMakeLists
"grpcio-tools",
]
Expand Down
2 changes: 1 addition & 1 deletion script/build
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def install_build_requires() -> None:
"install",
"--upgrade",
"pip",
"setuptools<64",
"setuptools",
"wheel",
"tomli",
*extra_req,
Expand Down
Loading