Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin setuptools #6089

Closed
wants to merge 7 commits into from
Closed

Unpin setuptools #6089

wants to merge 7 commits into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 12, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda force-pushed the unpin_setuptools branch 6 times, most recently from b2f1e59 to c7b0a5a Compare September 19, 2023 08:34
@dafeda dafeda self-assigned this Sep 19, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #6089 (7d6d74e) into main (d1ae20d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6089   +/-   ##
=======================================
  Coverage   82.48%   82.49%           
=======================================
  Files         350      350           
  Lines       21486    21486           
  Branches      826      826           
=======================================
+ Hits        17723    17725    +2     
+ Misses       3469     3467    -2     
  Partials      294      294           

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda force-pushed the unpin_setuptools branch 4 times, most recently from c7b0a5a to 7fa1b17 Compare September 19, 2023 10:07
@dafeda dafeda closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants